Rootless mode also bind service nodePort to host for LoadBalancer type#9512
Merged
brandond merged 1 commit intok3s-io:masterfrom Mar 1, 2024
Merged
Conversation
Signed-off-by: Edgar Lee <edgarhinshunlee@gmail.com>
8 tasks
briandowns
approved these changes
Feb 28, 2024
brandond
approved these changes
Feb 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9512 +/- ##
==========================================
- Coverage 49.12% 42.91% -6.21%
==========================================
Files 151 154 +3
Lines 13475 13529 +54
==========================================
- Hits 6619 5806 -813
- Misses 5515 6554 +1039
+ Partials 1341 1169 -172
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
When creating a service, typically the service port is for pod-to-pod access whereas nodePort is used for external access. In non-rootless mode, I was able to access a service of type LoadBalancer via localhost on both its service port and nodePort.
However, in rootless mode, I was only able to access it via localhost on its service port but not its nodePort.
Types of Changes
Rootless mode should also bind service nodePort to host for LoadBalancer type, matching UX of rootful mode.
Verification
kubectl applya simple pod &LoadBalancerservice withnodePortportandnodePortLinked Issues
nodePortfor rootless k3s #9511User-Facing Change